Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom Base Model #36

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Use custom Base Model #36

merged 2 commits into from
Jan 5, 2024

Conversation

mmwinther
Copy link
Member

@mmwinther mmwinther commented Jan 5, 2024 •
edited
Loading

This allows us to set config to control Pydantic behaviour.

We used this Base model prior to generating from JSON Schema.

@mmwinther
Use custom Base Model
060aa6b 
This allows us to set config to control Pydantic behaviour.
@mmwinther mmwinther requested review from BjornRoarJoneid and a team as code owners January 5, 2024 12:57
@github-actions github-actions bot added ci Continuous Integration python Updates to the generated Python project labels Jan 5, 2024
tilen1976
tilen1976 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@tilen1976 tilen1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mmwinther mmwinther merged commit 558092c into main Jan 5, 2024
1 check passed
@mmwinther mmwinther deleted the use-custom-basemodel branch January 5, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilen1976 tilen1976 tilen1976 approved these changes

@BjornRoarJoneid BjornRoarJoneid Awaiting requested review from BjornRoarJoneid BjornRoarJoneid is a code owner

Assignees
No one assigned
Labels
ci Continuous Integration python Updates to the generated Python project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmwinther @tilen1976