Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Dropdown: ensure reactivity of components 'selectedItem' prop #1111

Merged
merged 9 commits into from
Jun 25, 2024
Merged

[Bugfix] Dropdown: ensure reactivity of components 'selectedItem' prop #1111

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1abaef5
ensure reactivity of Dropdown components 'selectedItem' prop
skykanin Jun 13, 2024
d069b92
refactor code a bit
skykanin Jun 15, 2024
887d492
fix linting error
skykanin Jun 17, 2024
e7039c6
same fix for Input component
skykanin Jun 17, 2024
a3040d9
fix linting again
skykanin Jun 17, 2024
5bd0c07
Merge branch 'master' of https://github.com/statisticsnorway/ssb-comp…
johnnadeluy Jun 21, 2024
c5e67ce
remove changes to Input component
skykanin Jun 25, 2024
84fc91b
really restore changes to Input component
skykanin Jun 25, 2024
1a91792
fixup
skykanin Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/components/Dropdown/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,20 @@ const Dropdown = ({

const [isOpen, setOpen] = useState(open)
const [availableOptions, filterAvailableOptions] = useState(items || [])
const [selectedOption, selectItem] = useState(selectedItem || { title: '', id: '' })
const [activeOption, setActiveOption] = useState(selectedItem || { title: '', id: '' })
const DEFAULT_ITEM = { title: '', id: '' }
const [selectedOption, selectItem] = useState(selectedItem || DEFAULT_ITEM)
const [activeOption, setActiveOption] = useState(selectedItem || DEFAULT_ITEM)
const [inputFieldValue, updateInputValue] = useState('')
const [keyNavPosition, setKeyNavPosition] = useState(0)

const dropdownId = id || useId()

// ensure reactivity of 'selectedItem' prop is preserved
useEffect(() => {
selectItem(selectedItem || DEFAULT_ITEM)
setActiveOption(selectedItem || DEFAULT_ITEM)
}, [selectedItem])

const filterOptions = (value) => {
updateInputValue(value)
filterAvailableOptions(items.filter((it) => it.title.toLowerCase().includes(value.toLowerCase())))
Expand Down