Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIM-1747] Make highmap show in edit mode #2537

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

omsaggau
Copy link
Contributor

@omsaggau omsaggau commented Feb 13, 2024

@github-actions github-actions bot changed the title Make highmap show in edit mode [MIM-1747] Make highmap show in edit mode Feb 13, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

På linje 72 rendres en placeholder i stedet for å kjøre render på parten, så den når aldri koden du har endret på så i edit-mode når jeg setter inn en highmap-part ser det slik ut (se skjermbilde under). Er det med vilje?
Screenshot 2024-02-19 at 10 26 44

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tror vi beholder den for highmap parten. Visning i edit mode funker best når du er på selve highmap innholdet eller bruker det gjennom macro, funker litt dårlig når det er part.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Den fungerer forøvrig med visning både når jeg redigerer selve highmapen og som makro når jeg redigerer en artikkel. Så derfor lurer jeg på om den kunne ha vært rendret her også

@omsaggau omsaggau merged commit 5f27fb3 into develop Feb 20, 2024
9 checks passed
@omsaggau omsaggau deleted the MIM-1747_highmap-preview-edit branch February 20, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants