Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIM-1567] Removed double entry in stats calendar & removed unecessary code #2273

Closed

Conversation

michaelpande
Copy link
Contributor

@michaelpande michaelpande commented Nov 21, 2023

https://statistics-norway.atlassian.net/browse/MIM-1567

Deleted a lot of code, seems to work as intended with the new method of merging

Link to ticket: MIM-1567

@github-actions github-actions bot changed the title Removed double entry in stats calendar & removed unecessary code [MIM-1567] Removed double entry in stats calendar & removed unecessary code Nov 21, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@johnnadeluy johnnadeluy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code was added for the merging of content and statistics releases. Content releases are manually added and fetched from the CS repo whilst statistics releases are fetched from a dataset repo.

After the removal of code, content release don't appear in the Kommende publiseringer page anymore:
Screenshot 2023-11-22 at 1 32 31 PM

Månedlig statsregnskap (tabellene 05588 og 07107) oppdateres i Statistikkbanken is missing.

@michaelpande michaelpande deleted the MIM-1567-double-entry-in-stats-calendar branch December 1, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants