Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIM-1077] Improved user feedback on PIF calculator #2271

Merged
merged 2 commits into from
Nov 23, 2023
Merged

[MIM-1077] Improved user feedback on PIF calculator #2271

merged 2 commits into from
Nov 23, 2023

Conversation

annesiri
Copy link
Contributor

@annesiri annesiri commented Nov 21, 2023 •
edited by github-actions bot
Loading

@github-actions github-actions bot changed the title added logic to validate start year [MIM-1077] added logic to validate start year Nov 21, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@annesiri annesiri changed the title [MIM-1077] added logic to validate start year [MIM-1077] Improved user feedback on PIF calculator Nov 22, 2023
@annesiri annesiri marked this pull request as ready for review November 22, 2023 15:13
@annesiri annesiri assigned johnnadeluy and unassigned ssb-cgn Nov 23, 2023
johnnadeluy
johnnadeluy approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@johnnadeluy johnnadeluy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ✨

@annesiri annesiri merged commit ec834d3 into develop Nov 23, 2023
5 checks passed
@annesiri annesiri deleted the MIM-1077-improved-error-handling-in-pif-calculator branch November 23, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnadeluy johnnadeluy johnnadeluy approved these changes

Assignees

@johnnadeluy johnnadeluy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annesiri @johnnadeluy @ssb-cgn