Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed easy sonarcloud bugs #2163

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Fixed easy sonarcloud bugs #2163

merged 3 commits into from
Oct 19, 2023

Conversation

annesiri
Copy link
Contributor

Fixed sonarcloud issues tha require minimal changes and should not touch logic/refactoring of code. Some issues are done in separate tasks later.

Link: https://sonarcloud.io/project/issues?resolved=false&types=BUG&id=statisticsnorway_mimir&open=AYMMS1dSbIx-Cxvq32om

Sonarcloud bugs not fixed:

  • Highcharts code are done separately
  • RefreshStatisticsForm is fixed separately since this will touch logic

@annesiri annesiri marked this pull request as ready for review October 18, 2023 14:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@johnnadeluy johnnadeluy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great job ☀️

@annesiri annesiri merged commit 24ccb8b into master Oct 19, 2023
@annesiri annesiri deleted the fix-sonarcloud-bugs branch October 19, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants