Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version prettier and eslint-plugin-prettier #2137

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Update version prettier and eslint-plugin-prettier #2137

merged 6 commits into from
Oct 17, 2023

Conversation

annesiri
Copy link
Contributor

@annesiri annesiri commented Oct 9, 2023

  • updated version prettier and eslint-plugin-prettier
  • added rule for trailing comma
  • run autofix using "npm run lint" in repo

dependabot bot and others added 2 commits October 6, 2023 11:32
@dependabot
Bump prettier from 2.8.8 to 3.0.3
3a63ebd 
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.8 to 3.0.3.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.8...3.0.3)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@annesiri
updated prettier and eslint-plugin-prettier, fixed prettierrc
bd7c852
ssb-cgn
ssb-cgn approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@ssb-cgn ssb-cgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@annesiri
Copy link
Contributor Author

Venter med å merge til vi har deployet til prod

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

omsaggau
omsaggau approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@omsaggau omsaggau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annesiri annesiri merged commit b4b8ee3 into master Oct 17, 2023
@annesiri annesiri deleted the update-version-prettier-and-eslint-plugin-prettier branch October 17, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssb-cgn ssb-cgn ssb-cgn approved these changes

@omsaggau omsaggau omsaggau approved these changes

@Glenruben Glenruben Awaiting requested review from Glenruben

@johnnadeluy johnnadeluy Awaiting requested review from johnnadeluy

Assignees

@ssb-cgn ssb-cgn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annesiri @omsaggau @ssb-cgn