Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Thymeleaf Rendering Error by Handling Undefined Variables #2136

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

Carl-OW
Copy link
Contributor

@Carl-OW Carl-OW commented Oct 9, 2023

Resolved the Thymeleaf rendering error: "Exception evaluating OGNL expression: 'centerRegion.components'" (found in "mimir:/site/layouts/triple/triple.html" - line 11, col 12). Implemented a check for null or undefined variables before template parsing. Added a safeguard to assign empty arrays to variables if they are null or undefined, preventing Thymeleaf from throwing errors when a region is empty at render time.

@Carl-OW
Copy link
Contributor Author

Carl-OW commented Oct 9, 2023

mimir-1857

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@omsaggau omsaggau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Carl-OW Carl-OW merged commit 4984c18 into master Oct 11, 2023
6 checks passed
@Carl-OW Carl-OW deleted the mimir-1857-Layout-i-fragmenter-gir-feil branch October 12, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants