Mimir 1849 endre punktum til desimaltegn tooltip engelske highchart #2097
Conversation
changed decimalPoint from " , " to " . " in en version changed download text from nb to en (still need fix for nb to nn)
auto-assign
bot
requested review from
Glenruben,
johnnadeluy,
omsaggau and
ssb-cgn
There was a problem hiding this comment.
I suggest only including the translated phrases in the highchart-lang-en file to avoid duplication, and to then merge the two into a new json object when defining the english phrases if all the other phrases are intended to be in norwegian for english pages.
Alternatively, if the default language for highcharts is english then we can consider dropping the highcharts-lang-en.json file and only set accessibility options when the chart has to be translated to norwegian. Or keep the highchart-lang-en file with only the necessary english overwrites/rephrasing.
Also, don't forget to apply the changes to the Highmap and nameSearch components as well.
|
I have deleted highmap-lang-en.json and opted for another solution, where the default highcharts language is used for for the en version of the site and the accessibilityLang file is used for nb version, I also added the fix for nameSearch, so that the decimalPoints for the graphs are correct for each language, as well as the download-dropdown text, (mimir-1849 og mimir-1851) - also tested that voice-over works correctly |
|
Kudos, SonarCloud Quality Gate passed!
|
Fix for mimir-1849 og mimir-1851