Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move unnecessary methods out of DataDocMetadata class #360

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Move unnecessary methods out of DataDocMetadata class #360

merged 5 commits into from
Jul 4, 2024

Conversation

mmwinther
Copy link
Member

  • Extract _open_path
  • Move calculate_percentage
  • Move default spatial coverage description
  • Move get_assessment_from_state
  • Mark internal methods with leading underscore

@mmwinther mmwinther requested a review from a team as a code owner July 4, 2024 08:46
tilen1976
tilen1976 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@tilen1976 tilen1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mmwinther mmwinther merged commit f447361 into master Jul 4, 2024
16 checks passed
@mmwinther mmwinther deleted the chore/move-unnecessary-methods branch July 4, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilen1976 tilen1976 tilen1976 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmwinther @tilen1976