Chore/dpmeta 137 remove unused methods and classes #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/dpmeta-137-remove-unused-methods-and-classes
tilen1976
merged commit fd95de0
into
feat/update-dataset-tab-with-ssb-components
12 checks passed
tilen1976
deleted the
chore/dpmeta-137-remove-unused-methods-and-classes
branch
Jorgen-5
added a commit
that referenced
this pull request
Apr 2, 2024
* Fix/get old commit (#232) * new class * Changed properties in display_dataset --------- Co-authored-by: Jan Sander <[email protected]> * Feat/dpmeta 128 add unique key (#228) * Added dataset input field that uses ssb input * Updated builder for dataset input filed * Add DatasetDropdownField - change datatype DISPLAY_DATASET - temp commented out code * Change datatypes for Datasetidentifiers - som dropdowns ok - test red * DatasetDisplayTypes list * Dropdown options ok dataset * remove comment * Possible Const id for dataset * Changed tests to be compatible with new display dataset functions * Add unique dict id for Form * Add section_id to make Form ID unique * Ruff temporary commented out code --------- Co-authored-by: rlj <[email protected]> * Display and save metadata in dataset tab (#235) * Reading metadata dataset * Change className - update comment - values are displayed too late * add language id * Trigger dataset tab on button click and dynamic id on edit section * Revert changes in callback * Add Input from button click and return no_update when no click. Is working, but is not tested in every aspect * Update names dataset * Update and write docstrings * Remove commented out code * Refactor and comment * Remove comments as notes * Refactor build dataset edit section * fix merge * fix cirkular import * Update and add styling to dataset tab (#241) * workspace title * class names for workspace - update css * refactor variables tab semantics and type content in Tab * Add tests for build dataset edit section (#240) * Test assert return html.Section * Remove unnecessary code * Add tests * details test * Tests * datasetInputField * Update tests minus atypical options-getters * Organize and check tests - all ok * Rename * correct id * Keyword should not be excluded from the tests - not same issue as dropdowns from external sources (#242) * Added validation to the date picker in the dataset tab (#243) * Added validation to the date picker in the dataset tab * Updated dataset date tests * Fixed types for dataset tab dates --------- Co-authored-by: rlj <[email protected]> * Add method for get date metadata and stringify (#245) * Refactor Input and Dropdown * min should not be deleted * Changing metadata type * Changing type back to BaseModel * fix datetime format variables for display date (#254) * Refactor period field for dataset and variable (#255) * fix datetime format variables for display date * Add id_type to component * One periodField * update test * Added comments for noqas * Chore/dpmeta 137 remove unused methods and classes (#257) * Remove unused VariablesInputField and VariablesDropdownField * Remove input_kwargs * Move unused classes to bottom of file * Rename checkboxField * Change name from VariablesFieldTypes to MetadataFieldTypes * Correct name (#259) * Remove fontsize header - add margin-top buttons and rename css file --------- Co-authored-by: Jorgen-5 <[email protected]> Co-authored-by: Cecilie Seim <[email protected]> Co-authored-by: rlj <[email protected]> Co-authored-by: rlj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.