Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantiate the thread pool from the outermost layers #234

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Instantiate the thread pool from the outermost layers #234

merged 2 commits into from
Mar 18, 2024

Conversation

mmwinther
Copy link
Member

Using a with block for ThreadPoolExecutor is blocking, since all threads need to be finished to close the thread pool. This moves the with block outside app startup such that closing the thread pool occurs on app shutdown.

Ref: DPMETA-125

@mmwinther mmwinther requested a review from a team as a code owner March 18, 2024 09:27
JanhSander
JanhSander approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@JanhSander JanhSander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@mmwinther mmwinther merged commit 1d86e63 into master Mar 18, 2024
12 checks passed
@mmwinther mmwinther added the performance Performance label Mar 18, 2024
@mmwinther mmwinther deleted the fix/threadpool branch March 18, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanhSander JanhSander JanhSander approved these changes

Assignees
No one assigned
Labels
performance Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmwinther @JanhSander