Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct categorisation of dataset fields #221

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Correct categorisation of dataset fields #221

merged 2 commits into from
Mar 13, 2024

Conversation

Jorgen-5
Copy link
Contributor

@Jorgen-5 Jorgen-5 commented Mar 13, 2024 •
edited
Loading

  • Made the fields Dataset Status, Description, Version Description, Unit Type, and Temporality Type to be obligatory
  • Updated progress bar test to pass with the above change

@Jorgen-5 Jorgen-5 requested a review from a team as a code owner March 13, 2024 15:18
mmwinther
mmwinther approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@mmwinther mmwinther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

@Jorgen-5 Jorgen-5 changed the title Chore/correct categorization of dataset fields Correct categorisation of dataset fields Mar 13, 2024
@Jorgen-5 Jorgen-5 merged commit 8931e1b into master Mar 13, 2024
10 checks passed
@Jorgen-5 Jorgen-5 deleted the chore/correct-categorization-of-dataset-fields branch March 13, 2024 15:28
@tilen1976 tilen1976 mentioned this pull request Mar 14, 2024
Merged
tilen1976 added a commit that referenced this pull request Mar 14, 2024
@tilen1976 @Jorgen-5
Build dataset layout (#223)
17409f4 
* Correct categorisation of dataset fields (#221)

* Made multiple dataset fields obligatory

* Fixed progress bar test

---------

Co-authored-by: rlj <[email protected]>

* build edit section

* New dataset tab ok

* Add edit_sections

---------

Co-authored-by: Jorgen-5 <[email protected]>
Co-authored-by: rlj <[email protected]>
@mmwinther mmwinther added the enhancement New feature or request label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmwinther mmwinther mmwinther approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jorgen-5 @mmwinther