Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove variables datatable interface #207

Merged
merged 8 commits into from
Mar 8, 2024

Conversation

mmwinther
Copy link
Member

@mmwinther mmwinther commented Mar 7, 2024

  • Remove variables table code
  • Remove feature toggle
  • Rename symbols with "new" to more simple, logical names

Screenshot 2024-03-07 at 15 43 27

Ref: DPMETA-101

@mmwinther mmwinther requested a review from a team as a code owner March 7, 2024 14:22
@mmwinther mmwinther added the refactoring Refactoring label Mar 7, 2024
Copy link
Contributor

@tilen1976 tilen1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but one issue with dates. When an error has occurred in contains_date_until and you want to correct contains_date_from, the error in contains_date_until remains (even if the dates are in order) and the date contains_date_until is not saved to file

Copy link

sonarqubecloud bot commented Mar 8, 2024

@mmwinther mmwinther merged commit 70d0222 into master Mar 8, 2024
15 checks passed
@mmwinther mmwinther deleted the chore/dpmeta-101-remove-variables-datatable branch March 8, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants