Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to owner #206

Merged
merged 12 commits into from
Mar 11, 2024
Merged

Changes to owner #206

merged 12 commits into from
Mar 11, 2024

Conversation

JanhSander
Copy link
Contributor

  • Changed owner to dropdown
  • Populated owner with values from klass
  • Adjustments in unit tests

@JanhSander JanhSander requested a review from a team as a code owner March 7, 2024 10:17
Copy link
Member

@mmwinther mmwinther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments 😇

src/datadoc/backend/code_list.py Outdated Show resolved Hide resolved
src/datadoc/backend/code_list.py Outdated Show resolved Hide resolved
src/datadoc/backend/code_list.py Outdated Show resolved Hide resolved
src/datadoc/backend/code_list.py Outdated Show resolved Hide resolved
@mmwinther mmwinther added the enhancement New feature or request label Mar 7, 2024
@JanhSander JanhSander force-pushed the feat/dpmeta-62-add-klass-codes-to-owner branch from 7cdc898 to 3cb49df Compare March 8, 2024 10:31
Copy link
Member

@mmwinther mmwinther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 😄

Copy link

@JanhSander JanhSander merged commit 9c547f8 into master Mar 11, 2024
15 checks passed
@JanhSander JanhSander deleted the feat/dpmeta-62-add-klass-codes-to-owner branch March 11, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants