Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch unit types items from klass #203

Merged
merged 12 commits into from
Mar 5, 2024
Merged

Fetch unit types items from klass #203

merged 12 commits into from
Mar 5, 2024

Conversation

Jorgen-5
Copy link
Contributor

@Jorgen-5 Jorgen-5 commented Mar 5, 2024

  • Updated to use new datadoc model
  • Added multiple languages for unit types
  • Added unit types to dropdown
  • Saved unit codes to the model
  • Added tests for multiple languages

@Jorgen-5 Jorgen-5 requested a review from a team as a code owner March 5, 2024 09:56
mmwinther
mmwinther requested changes Mar 5, 2024
View reviewed changes
Copy link
Member

@mmwinther mmwinther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I found a few small things that need changing, nothing major though.

src/datadoc/backend/unit_types.py Show resolved Hide resolved
src/datadoc/config.py Outdated Show resolved Hide resolved
tests/resources/utdata/befolkning/person_testdata_p2021-12-31_p2021-12-31_v1__DOC.json Outdated Show resolved Hide resolved
tests/resources/statistikk/befolkning/person_testdata_p2021-12-31_p2021-12-31_v1__DOC.json Outdated Show resolved Hide resolved
tests/resources/inndata/befolkning/person_testdata_p2021-12-31_p2021-12-31_v1__DOC.json Outdated Show resolved Hide resolved
@JanhSander JanhSander self-requested a review March 5, 2024 12:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mmwinther mmwinther changed the title Feat/add klass unit types to dropdown Fetch unit types items from klass Mar 5, 2024
@mmwinther mmwinther added the enhancement New feature or request label Mar 5, 2024
mmwinther
mmwinther approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@mmwinther mmwinther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Jorgen-5 Jorgen-5 merged commit 14d515f into master Mar 5, 2024
15 checks passed
@Jorgen-5 Jorgen-5 deleted the feat/add_klass_unit_types_to_dropdown branch March 5, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanhSander JanhSander JanhSander approved these changes

@mmwinther mmwinther mmwinther approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jorgen-5 @mmwinther @JanhSander