Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ssb-datadoc-model v4.1.2 #120

Merged
merged 12 commits into from
Jan 10, 2024
Merged

Use ssb-datadoc-model v4.1.2 #120

merged 12 commits into from
Jan 10, 2024

Conversation

mmwinther
Copy link
Member

@mmwinther mmwinther commented Jan 9, 2024

  • Update imports and names as necessary
  • Include new fields
  • Support the new metadata container
  • Backwards compatibility now runs all needed handler functions in order
  • Some restructuring in the DatadocMetadata class
  • Remove some unneeded dependencies
  • Move all the multi-language enums into this repo now that they're not available in the model
  • Update test metadata files

Ref: DPMETA-4

Copy link

github-actions bot commented Jan 9, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
datadoc
   app.py521277%87–88, 115–130, 134
   enums.py79791%12, 45–52
   state.py6183%18
   utils.py30680%39, 51–55, 60
   wsgi.py330%3–6
datadoc/backend
   __init__.py00100% 
   datadoc_metadata.py117596%22, 58–59, 183–184
   dataset_parser.py67593%123–124, 192–194
   model_backwards_compatibility.py53394%22, 41, 80
   storage_adapter.py741382%14, 32, 43–45, 77–78, 136, 140, 147, 151, 155, 160
datadoc/frontend/callbacks
   __init__.py00100% 
   dataset.py672464%31–35, 45, 57–63, 71–90, 98–100, 114, 116
   register_callbacks.py411661%29, 46–47, 56–62, 85, 101, 130–133, 143–144, 166
   utils.py24388%13–17
   variables.py56689%80–97, 118
datadoc/frontend/components
   __init__.py00100% 
   alerts.py70100% 
   builders.py230100% 
   control_bars.py150100% 
   dataset_tab.py100100% 
   variables_tab.py90100% 
datadoc/frontend/fields
   __init__.py00100% 
   display_base.py54689%15–21, 72
   display_dataset.py470100% 
   display_variables.py350100% 
TOTAL86911087% 

Tests Skipped Failures Errors Time
113 0 💤 0 ❌ 0 🔥 2.849s ⏱️

@mmwinther mmwinther changed the title Use ssb-datadoc-model v4.1.0 Use ssb-datadoc-model v4.1.2 Jan 10, 2024
@mmwinther mmwinther marked this pull request as ready for review January 10, 2024 09:49
@mmwinther mmwinther requested a review from a team as a code owner January 10, 2024 09:49
tilen1976
tilen1976 previously approved these changes Jan 10, 2024
Copy link
Contributor

@tilen1976 tilen1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except from the local path

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mmwinther mmwinther merged commit ca4ce7d into master Jan 10, 2024
4 checks passed
@mmwinther mmwinther deleted the use-model-v4.1.0 branch January 10, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants