Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS #119

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Update CODEOWNERS #119

merged 1 commit into from
Jan 4, 2024

Conversation

mmwinther
Copy link
Member

Team Metadata is taking ownership of this product, update CODEOWNERS to reflect this.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mmwinther mmwinther requested a review from a team January 4, 2024 13:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
datadoc
   app.py521277%87–88, 115–130, 134
   state.py6183%18
   utils.py27581%46–50, 55
   wsgi.py330%3–6
datadoc/backend
   __init__.py00100% 
   datadoc_metadata.py105496%22, 170–177
   dataset_parser.py68593%124–125, 193–195
   model_backwards_compatibility.py37295%18, 37
   storage_adapter.py741382%14, 32, 43–45, 77–78, 136, 140, 147, 151, 155, 160
datadoc/frontend/callbacks
   __init__.py00100% 
   dataset.py642167%28–31, 41, 53–55, 63–82, 90–92, 106, 108
   register_callbacks.py411661%29, 46–47, 56–62, 85, 101, 130–133, 143–144, 166
   utils.py21290%13–14
   variables.py56395%90–97
datadoc/frontend/components
   __init__.py00100% 
   alerts.py70100% 
   builders.py230100% 
   control_bars.py150100% 
   dataset_tab.py100100% 
   variables_tab.py90100% 
datadoc/frontend/fields
   __init__.py00100% 
   display_base.py53689%15–21, 72
   display_dataset.py450100% 
   display_variables.py350100% 
TOTAL7519388% 

Tests Skipped Failures Errors Time
104 0 💤 0 ❌ 0 🔥 5.532s ⏱️

tilen1976
tilen1976 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@tilen1976 tilen1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mmwinther mmwinther merged commit ac82786 into master Jan 4, 2024
3 checks passed
@mmwinther mmwinther deleted the codeowners branch January 4, 2024 14:11
mmwinther added a commit that referenced this pull request Jan 11, 2024
@mmwinther
Update CODEOWNERS (#119)
c58a2fe
@mmwinther mmwinther mentioned this pull request Jan 11, 2024
Merged
mmwinther added a commit that referenced this pull request Jan 12, 2024
@mmwinther
Use ssb-pypitemplate (#121)
6eb37a6 
* Bump ssb_datadoc_model to v4.1.0

- Remove unused dependencies
- Update dependencies

* Change all imports, handle multi-language enums

* Green unit tests

* Remove commented line

* Don't delete SECURITY.md

* Bump ssb_datadoc_model to 4.1.2

* Don't use deprecated pkg_resources

* Use values from the enums in the model where possible

* Add unit tests for get_language_strings_enum

* Fix unit test

* Release v0.4.0

* Remove reference to local path

* Update CODEOWNERS (#119)

* Use ssb-pypitemplate

* Satisfy mypy

* Fix test data format

* Fix workflow python versions

* Don't use platform-specific path for a URL

* Fix Docker build

* Fix another path in Dockerfile

* More fix paths

* Update documentation

* Remove .DS_Store files

* Remove darglint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilen1976 tilen1976 tilen1976 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmwinther @tilen1976