Set fixture remove_document_file on autouse (#132)

* Run fixture remove_document_file automatically on all tests to remove file linked in testcases

* Replaced try/except in fixture with if statement

tests/backend/test_datadoc_metadata.py

@@ -62,7 +62,7 @@ def test_get_dataset_state(
     assert actual_state == expected_result
 
 
-@pytest.mark.usefixtures("existing_metadata_file", "remove_document_file")
+@pytest.mark.usefixtures("existing_metadata_file")
 def test_existing_metadata_file(
     metadata: DataDocMetadata,
 ):
@@ -99,7 +99,6 @@ def test_get_dataset_version(
     assert DataDocMetadata.get_dataset_version(short_name) == expected
 
 
-@pytest.mark.usefixtures("remove_document_file")
 def test_write_metadata_document(
     dummy_timestamp: datetime,
     metadata: DataDocMetadata,
@@ -134,7 +133,7 @@ def test_write_metadata_document(
     assert datadoc_metadata["metadata_last_updated_by"] == PLACEHOLDER_USERNAME
 
 
-@pytest.mark.usefixtures("existing_metadata_file", "remove_document_file")
+@pytest.mark.usefixtures("existing_metadata_file")
 def test_write_metadata_document_existing_document(
     dummy_timestamp: datetime,
     metadata: DataDocMetadata,
@@ -156,7 +155,6 @@ def test_metadata_id(metadata: DataDocMetadata):
     "existing_metadata_path",
     [TEST_EXISTING_METADATA_DIRECTORY / "invalid_id_field"],
 )
-@pytest.mark.usefixtures("remove_document_file")
 def test_existing_metadata_none_id(
     existing_metadata_file: str,
     metadata: DataDocMetadata,
@@ -175,7 +173,6 @@ def test_existing_metadata_none_id(
     "existing_metadata_path",
     [TEST_EXISTING_METADATA_DIRECTORY / "valid_id_field"],
 )
-@pytest.mark.usefixtures("remove_document_file")
 def test_existing_metadata_valid_id(
     existing_metadata_file: str,
     metadata: DataDocMetadata,

tests/backend/test_model_backwards_compatibility.py

@@ -36,7 +36,6 @@ def test_existing_metadata_unknown_model_version():
     BACKWARDS_COMPATIBLE_VERSION_DIRECTORIES,
     ids=BACKWARDS_COMPATIBLE_VERSION_NAMES,
 )
-@pytest.mark.usefixtures("remove_document_file")
 def test_backwards_compatibility(
     existing_metadata_file: str,
     metadata: DataDocMetadata,

tests/conftest.py

@@ -1,7 +1,6 @@
 """Shared fixtures and configuration."""
 
 import shutil
-import traceback
 from collections.abc import Generator
 from datetime import datetime
 from datetime import timezone
@@ -43,15 +42,12 @@ def metadata(_mock_timestamp: None) -> DataDocMetadata:
     return DataDocMetadata(str(TEST_PARQUET_FILEPATH))
 
 
-@pytest.fixture()
+@pytest.fixture(autouse=True)
 def remove_document_file() -> Generator[None, None, None]:
     # Yield so we only run teardown
     yield None
-    try:
+    if TEST_RESOURCES_METADATA_DOCUMENT.exists():
         TEST_RESOURCES_METADATA_DOCUMENT.unlink()
-    except FileNotFoundError as e:
-        print("File not deleted on teardown, exception caught:")  # noqa: T201
-        traceback.print_exception(type(e), e)
 
 
 @pytest.fixture()