Fix useEffect array dependencies for pages with tabs; causes issues o…

…n Table view
statisticsnorway · Feb 28, 2024 · 418edee · 418edee
1 parent 12bd39c
commit 418edee
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/pages/TeamMembers/TeamMembers.tsx b/src/pages/TeamMembers/TeamMembers.tsx
@@ -1,3 +1,4 @@
+/* eslint-disable react-hooks/exhaustive-deps */
 import { useCallback, useEffect, useState } from 'react'
 import { Dialog, Text, Link, Tabs, Divider } from '@statisticsnorway/ssb-component-library'
 
@@ -57,13 +58,13 @@ const TeamMembers = () => {
       .catch((error) => {
         setError(error as ApiError)
       })
-  }, [prepUserData, jwt])
+  }, [])
 
   useEffect(() => {
     if (teamMembersData) {
-      setTeamMembersTableData(prepUserData(teamMembersData))
+      setTeamMembersTableData(prepUserData(teamMembersData)) // Update Table view on Tab onClick
     }
-  }, [teamMembersData, prepUserData])
+  }, [prepUserData])
 
   const handleTabClick = (tab: string) => {
     setActiveTab(tab)

diff --git a/src/pages/TeamOverview/TeamOverview.tsx b/src/pages/TeamOverview/TeamOverview.tsx
@@ -1,3 +1,4 @@
+/* eslint-disable react-hooks/exhaustive-deps */
 import { useCallback, useEffect, useState } from 'react'
 import { Dialog, Text, Link, Tabs, Divider } from '@statisticsnorway/ssb-component-library'
 
@@ -54,13 +55,13 @@ const TeamOverview = () => {
       .catch((error) => {
         setError(error.toString())
       })
-  }, [prepTeamData])
+  }, [])
 
   useEffect(() => {
     if (teamOverviewData) {
-      setTeamOverviewTableData(prepTeamData(teamOverviewData))
+      setTeamOverviewTableData(prepTeamData(teamOverviewData)) // Update Table view on Tab onClick
     }
-  }, [teamOverviewData, prepTeamData])
+  }, [prepTeamData])
 
   const handleTabClick = (tab: string) => {
     setActiveTab(tab)