-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the concept of "page", with a dedicated "pages" folder like Jekyll #25
Comments
Changes already pushed to #23. @daveaglick I'm sorry for not even waiting for your reply, but the |
ditto: multiple PRs with small amount of changes is much better |
@atiq-cs I fail to see how this issue could be split. The bullet points under "Implementation" make little to no sense if singled out. Anyway, this issue is moot since the problem was created halfway in #23 and the fix is already in a later commit in #23. Even if #23 gets abandoned in favor of smaller PRs, I'll just avoid creating the problem in the first place. |
Hi Guys, Change in this commit 8c248f0 as part of this PR has regressed build performance. As a result of that, our large blog with 819 posts has started failing since pulling in this change. Our blog successfully builds till commit 8c248f0 is pulled. To provide more context, our blog usually builds in 6 minutes. Since pulling this change / commit 8c248f0 it has been building for forever. It's also failing on the cloud instance since pulling in this change due to time outs. I request re-reviewing the change introduced and what changed that increased build time dramatically! Please let me know if you need any other debug / diagnostic info. Here's output of
|
@daveaglick need to re-open this issue please if it makes sense from above! |
- reverses commit 8c248f0 partially ref. statiqdev#24, rel. statiqdev#25
- reverses commit 8c248f0 partially ref. statiqdev#24, rel. statiqdev#25
Background and motivation
The upstream project distinguishes between a "post" a "page" and a... "neither-post-nor-page", let's call it "infrastructure" (home, posts, tags).
As far as I can tell, the only current difference between the three kinds of pages should be the CSS class of the title / description
<div>
:post-heading
for posts,page-heading
for pages,site-heading
for infrastructure. However, the conceptual distinction is more important than just the CSS class, because the StartBootstrap team may decide to, say, use different masthead colors for posts and pages, and we wouldn't be able to implement that if we can't tell what a "page" is.#23 adds an
IsArchive
setting which is similar in purpose (a "neither-post-nor-archive" is a "page") but anIsPage
setting would probably make more sense, as it maps easily to the concept of "page" in Jekyll, Wordpress, and probably others.Implementation
IsArchive
setting (I could do this directly in Update dependencies, refactor styles and scripts, add some goodies #23 before it gets merged).Add a(EDIT: no sense in forcing a page to exist on user sites; a decently-written section in README will do)pages
folder underinput
with anabout.md
file (that will be overridden by users) to demonstrate the feature.PageSources
andIsPage
settings insettings.yml
:_header.cshtml
from this:to this:
Styling for the
page-heading
class is already implemented and imported, we just never got to see it so far.IsArchive
was used to tell apart pages from infrastructure.Incompatibilities
An existing blog's "About" page will not see any changes, unless the author adds
IsPage: true
to front matter.If an author wants to keep existing pages in
input
they have to exclude thepages
folder from processing; it shouldn't be hard AFAIK, but I'd advise moving pages underpages
and using redirects instead.@daveaglick any thoughts? Should I add this to #23 instead of the
IsArchive
mess (admittedly of my creation)?The text was updated successfully, but these errors were encountered: