Skip to content
This repository has been archived by the owner on Sep 10, 2023. It is now read-only.

change memory usage to bit fields #4

Merged
merged 2 commits into from
Sep 24, 2017
Merged

Conversation

Sanaloht
Copy link

char arrays for parsed cronexpr changed to uint8_t* bit fields
added tests for memory allocation

char arrays for parsed cronexpr changed to uint8_t* bit fields
added tests for memory allocation
@staticlibs
Copy link
Owner

Hi, the PR looks good, thanks! The only unclear thing is, why gmtime_s changed to gmtime on windows?

Besides that, can you please make it pass "compile and test" commands from here at least for some of the compilers? I really like to keep it "warning-free", currently cannot test the updated version with my app because of warnings.

@staticlibs
Copy link
Owner

Forgot another bit, could you please rename TEST macro to CRON_TEST_MALLOC or something like this?

@Sanaloht
Copy link
Author

Macroname is fixed and use of the define extended.
The gmtime_s issues are partially due to c89 standard but mostly due to mingw32.
Defines now change if mingw is used. Can you test it now?

@staticlibs
Copy link
Owner

@Sanaloht Thanks for the update! Smoke tests are passing for me. Going to look deeper and merge it in a day or two.

@staticlibs staticlibs merged commit 88c2148 into staticlibs:master Sep 24, 2017
@staticlibs
Copy link
Owner

Merged and fixed and changed some minor things. Overall bitfields are very nice to have. Thanks again for PR!

@staticlibs staticlibs mentioned this pull request Sep 24, 2017
@ThomTe
Copy link
Contributor

ThomTe commented Sep 25, 2017

You're welcome and thanks to Niondir for helping!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants