Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to more current features of Homebrew #71

Merged
merged 4 commits into from
Mar 14, 2014
Merged

Migrate to more current features of Homebrew #71

merged 4 commits into from
Mar 14, 2014

Conversation

jacknagel
Copy link
Contributor

Hi, this pull request migrates the Julia formula to use more current features of Homebrew:

  • Use resources instead of subformulae. Resources are downloaded when you brew fetch a formula, and have a few other nifty features, though I've just demonstrated basic usage here.
  • Use blocks to declare stable and head specific dependencies. This is the preferred way to handle stable/devel/head dependencies, as using conditionals presents a number of problems and can result in the wrong set of dependencies being selected in certain situations. These blocks currently support dependencies, options, and resources, and other DSL methods (fails_with in particular) will be supported eventually.
  • Use Formula["name"] instead of Formula.factory("name"). This is more of a stylistic thing, but factory will probably become an audit warning in the future.
  • Fully specify the dependency on homebrew/versions/llvm33, which will cause the installer to tap homebrew-versions automatically.

I am sending this PR because I want people to adopt these practices, and because I've been working on some improvements to dependency and option handling, and I want the way people are using existing features, or working around them, to guide future development.

@staticfloat
Copy link
Owner

Thanks for this, Jack!

staticfloat added a commit that referenced this pull request Mar 14, 2014
Migrate to more current features of Homebrew
@staticfloat staticfloat merged commit 33b901d into staticfloat:master Mar 14, 2014
@jacknagel jacknagel deleted the modernize branch March 15, 2014 02:37
@ianml ianml mentioned this pull request Mar 15, 2014
@wjj2329 wjj2329 mentioned this pull request Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants