Added SSR and OG image tags to visualised machines #198

mattpocock · 2021-08-19T15:21:36Z

No description provided.

changeset-bot · 2021-08-19T15:21:37Z

⚠️ No Changeset found

Latest commit: 215dbe0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2021-08-19T15:21:38Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/statelyai/xstate-viz/ABE1jcZdhWNCotSBKyEKtKtkwQAH
✅ Preview: https://xstate-viz-git-matt-added-ssr-and-og-image-tag-c60af3-statelyai.vercel.app

…-ssr-and-og-image-tags-to-visualised-machines

src/AppHead.tsx

src/pages/[sourceFileId].tsx

src/sourceMachine.ts

Co-authored-by: Mateusz Burzyński <[email protected]>

Andarist · 2021-08-24T12:04:54Z

src/AppHead.tsx

+   * whereas titles in the <title> attribute
+   * should be SEO-friendly
+   *
+   * ogTitle: My Great Machine


With this

Suggested change

* ogTitle: My Great Machine

* @example

* ogTitle: My Great Machine

it can render slightly better in the IDE.

Before

After

cypress/support/commands.ts

src/ShareButton.tsx

Andarist · 2021-08-24T12:50:20Z

.changeset/tiny-chicken-worry.md

+"xstate-viz-app": patch
+---
+
+Added SSR and OG image tags to visualised machines, and put visualised machines on a new, prettier URL - `/viz/:id`


All 3 things are completely separate and unrelated from the user's PoV. Don't be afraid of creating more than a single changeset per PR :)

I'm not sure if SSR is that interesting to our users - but the other ones definitely are! A sample OG image could also be attached to a changeset mentioning this improvement.

src/registryLinks.ts

Andarist · 2021-08-25T11:37:17Z

src/pages/[sourceFileId].tsx

+    if (!result.data?.getSourceFile) {
+      return {
+        notFound: true,
+        props: {} as any,


It typechecks just fine without it:

Suggested change

props: {} as any,

The notFound is already included in the union here:
https://github.com/vercel/next.js/blob/53f0973abaa5db4961dc03b226698d3c4ddbcf2b/packages/next/types/index.d.ts#L162-L165

…-ssr-and-og-image-tags-to-visualised-machines

mattpocock · 2021-08-27T09:10:59Z

Going to delete the changesets and add them to a later PR when we turn the feature flag on

Added SSR and OG image tags to visualised machines

0c5f43d

mattpocock requested review from Andarist, davidkpiano and farskid August 19, 2021 15:21

Create tiny-chicken-worry.md

0781cd4

vercel bot deployed to Preview August 19, 2021 15:24 View deployment

vercel bot deployed to Preview August 19, 2021 15:31 View deployment

Added image to share button

799f48d

vercel bot deployed to Preview August 20, 2021 09:03 View deployment

Fixed Cypress tests

26a95a2

vercel bot deployed to Preview August 20, 2021 10:10 View deployment

mattpocock marked this pull request as ready for review August 20, 2021 10:10

Merge branch 'dev' of github.com:statelyai/xstate-viz into matt/added…

dea5fa3

…-ssr-and-og-image-tags-to-visualised-machines

vercel bot deployed to Preview August 20, 2021 12:41 View deployment

Andarist reviewed Aug 24, 2021

View reviewed changes

src/AppHead.tsx Outdated Show resolved Hide resolved

Delete NoSSR.tsx

1036e2a

vercel bot deployed to Preview August 24, 2021 10:04 View deployment

Andarist reviewed Aug 24, 2021

View reviewed changes

src/pages/[sourceFileId].tsx Outdated Show resolved Hide resolved

Andarist reviewed Aug 24, 2021

View reviewed changes

src/pages/[sourceFileId].tsx Show resolved Hide resolved

Andarist reviewed Aug 24, 2021

View reviewed changes

src/sourceMachine.ts Outdated Show resolved Hide resolved

Update src/sourceMachine.ts

460f3cd

Co-authored-by: Mateusz Burzyński <[email protected]>

vercel bot deployed to Preview August 24, 2021 10:20 View deployment

mattpocock added 2 commits August 24, 2021 11:22

Removed unnecessary OG tags

e6bc31c

Added og title and fixed inconsistent Britishness on Visualizer

44a8a19

vercel bot deployed to Preview August 24, 2021 10:23 View deployment

Added comment explaining og title

9aa94d8

vercel bot deployed to Preview August 24, 2021 10:25 View deployment

mattpocock requested a review from Andarist August 24, 2021 10:25

Andarist reviewed Aug 24, 2021

View reviewed changes

cypress/support/commands.ts Outdated Show resolved Hide resolved

Andarist reviewed Aug 24, 2021

View reviewed changes

src/ShareButton.tsx Outdated Show resolved Hide resolved

Andarist reviewed Aug 24, 2021

View reviewed changes

src/registryLinks.ts Show resolved Hide resolved

Update src/App.tsx

aef2144

vercel bot deployed to Preview August 24, 2021 12:59 View deployment

Added @example tags to comments

19aa424

vercel bot deployed to Preview August 25, 2021 08:25 View deployment

Made ShareButton use a Link component

8f4057d

vercel bot deployed to Preview August 25, 2021 08:29 View deployment

Changed changesets

a356715

vercel bot deployed to Preview August 25, 2021 08:34 View deployment

Change Cypress command based on @Andarist's recommendation

48e11d3

vercel bot deployed to Preview August 25, 2021 08:41 View deployment

mattpocock requested a review from Andarist August 25, 2021 08:42

Andarist reviewed Aug 25, 2021

View reviewed changes

Andarist approved these changes Aug 25, 2021

View reviewed changes

Merge branch 'dev' of github.com:statelyai/xstate-viz into matt/added…

7d01672

…-ssr-and-og-image-tags-to-visualised-machines

vercel bot deployed to Preview August 26, 2021 14:15 View deployment

Added feature flag to OG images

9036bf4

vercel bot deployed to Preview August 26, 2021 14:50 View deployment

Delete dry-news-refuse.md

8889ccc

vercel bot deployed to Preview August 27, 2021 09:11 View deployment

Delete pink-pianos-wonder.md

215dbe0

mattpocock merged commit 784ded9 into dev Aug 27, 2021

mattpocock deleted the matt/added-ssr-and-og-image-tags-to-visualised-machines branch August 27, 2021 09:11

vercel bot deployed to Preview August 27, 2021 09:12 View deployment

github-actions bot mentioned this pull request Sep 23, 2021

Version Packages #242

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added SSR and OG image tags to visualised machines #198

Added SSR and OG image tags to visualised machines #198

mattpocock commented Aug 19, 2021 •

edited

Loading

changeset-bot bot commented Aug 19, 2021 •

edited

Loading

vercel bot commented Aug 19, 2021 •

edited

Loading

Andarist Aug 24, 2021

Andarist Aug 24, 2021

Andarist Aug 25, 2021

mattpocock commented Aug 27, 2021

	* ogTitle: My Great Machine
	* @example
	* ogTitle: My Great Machine

Added SSR and OG image tags to visualised machines #198

Added SSR and OG image tags to visualised machines #198

Conversation

mattpocock commented Aug 19, 2021 • edited Loading

changeset-bot bot commented Aug 19, 2021 • edited Loading

⚠️ No Changeset found

vercel bot commented Aug 19, 2021 • edited Loading

Andarist Aug 24, 2021

Choose a reason for hiding this comment

Andarist Aug 24, 2021

Choose a reason for hiding this comment

Andarist Aug 25, 2021

Choose a reason for hiding this comment

mattpocock commented Aug 27, 2021

mattpocock commented Aug 19, 2021 •

edited

Loading

changeset-bot bot commented Aug 19, 2021 •

edited

Loading

vercel bot commented Aug 19, 2021 •

edited

Loading