Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

family = "multinomial" #15

Open
adw96 opened this issue Jun 19, 2024 · 4 comments
Open

family = "multinomial" #15

adw96 opened this issue Jun 19, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@adw96
Copy link
Contributor

adw96 commented Jun 19, 2024

This is underway in #10, with some final bells and whistles and checks still TODO. This issue is just so we can keep track of this outside of the PR.

@adw96
Copy link
Contributor Author

adw96 commented Jun 19, 2024

Also a place to track the development of a vignette

@adw96
Copy link
Contributor Author

adw96 commented Jul 8, 2024

With PR #17 , can we close this, @svteichman ? 🙏 Alternatively, what is on our TODO list for multinomial?

@svteichman
Copy link
Collaborator

svteichman commented Jul 9, 2024

@adw96 As far as I can tell from looking at your comments on PR #10, we are missing the following:

  • vignette
  • formula notation

Additionally, a general $H$ matrix, although this is logged under it's own issue.

We'd discussed bringing the Poisson test and multinomial test together into a single function but decided not to for now because they use several distinct arguments and test different null hypotheses (and we currently don't have a test for a single parameter in a multinomial logistic regression model).

@svteichman
Copy link
Collaborator

The formula is now included, so this is just missing a vignette now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants