Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for Firth-penalty for fitting GLM using brglm2 package #12

Open
svteichman opened this issue May 24, 2024 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@svteichman
Copy link
Collaborator

Look into stability of brglm2, then add as an option (replacing glm.fit with brglm.fit as needed) for running glm to adding Firth penalty functionality. This will require a bit of craftiness to go from a design matrix (what raoBust uses to drop a column to estimate under the null) to a formula and data object (what brglm expects).

@svteichman svteichman self-assigned this May 24, 2024
@svteichman svteichman added the enhancement New feature or request label May 24, 2024
@adw96
Copy link
Contributor

adw96 commented May 24, 2024

@svteichman I'm just chatting w David and he confirmed he had no issues with brglm2. I was thinking of logistf, which we had significant issues with when implementing happi.

David did say brglm2 breaks/takes ages for multinomial logistic regression with many categories (large $J$), such as we see in radEmu-type problems.

@adw96
Copy link
Contributor

adw96 commented Jun 19, 2024

I think a next step after #15 is to implement a Firth penalty for multinomial as well. From there I think we will mostly have what we need to share this with the collaborator who requested it 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants