-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Add install:collaboration
command
#9760
Conversation
This reverts commit ed49494.
Laravel *also* seems to display info after a "thing" has been generated.
When we were doing `exit(1)`, it was causing the test suite to not complete running.
When running the test suite on Laravel 10.0.0, Prompts would show me the interactive prompt, meaning the assertions wouldn't take place. Related: laravel/framework#48468
…llaboration-command
e8539b6
to
97cf512
Compare
You can tell where I borrowed this code from, eh?
…on-command # Conflicts: # composer.json
…on-command # Conflicts: # composer.json
# Conflicts: # src/Providers/ConsoleServiceProvider.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run this, I immediately get an error about Pusher
because it's not installed.
sandbox on master [!?]
→ plz install:collaboration
Statamic\Console\Processes\Exceptions\ProcessException
./composer.json has been updated
Running composer update statamic/collaboration --with-dependencies
> Statamic\Console\Composer\Scripts::preUpdateCmd
Loading composer repositories with package information
Dependency statamic/cms is also a root requirement. Package has not been listed as an update argument, so keeping locked at old version. Use --with-all-dependencies (-W) to include root dependencies.
Updating dependencies
Lock file operations: 1 install, 0 updates, 0 removals
- Locking statamic/collaboration (dev-statamic-5-support 36d0846)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
- Installing statamic/collaboration (dev-statamic-5-support 36d0846): Extracting archive
- Downloading statamic/collaboration (dist)
Failed to download
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi
Error
Class "Pusher\Pusher" not found
at vendor/laravel/framework/src/Illuminate/Broadcasting/BroadcastManager.php:306
302▕ * @return \Pusher\Pusher
303▕ */
304▕ public function pusher(array $config)
305▕ {
➜ 306▕ $pusher = new Pusher(
When we use the `Broadcast` facade in the Collaboration addon's `ServiceProvider`, if the `BROADCAST_DRIVER` is `pusher`, you'll see an error when the Pusher driver hasn't yet been installed.
@jasonvarga It looks like this was happening due to the Collaboration addon's This would only happen if the To fix this, I've pushed up a fix which'll prevent composer scripts from running when we initially require |
This pull request introduces a new
install:collaboration
command which makes it really easy to setup Laravel's broadcast scaffolding, install a broadcast driver (like Laravel Reverb or Pusher) and install thestatamic/collaboration
package, all in a single command.Related: laravel/framework#50662