Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving Fieldtypes consistency #4458

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Improving Fieldtypes consistency #4458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb4b235
French translations
ebeauchamps Oct 6, 2021
872441f
Fixing French translations
ebeauchamps Oct 7, 2021
6d26c44
Fieldtypes consistency - closing #3130
ebeauchamps Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Fieldtypes/ButtonGroup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ protected function configFieldItems(): array
'display' => __('Options'),
'instructions' => __('statamic::fieldtypes.radio.config.options'),
'type' => 'array',
'value_header' => __('Label'),
'value_header' => __('Label').' ('.__('Optional').')',
],
'default' => [
'display' => __('Default Value'),
Expand Down
4 changes: 2 additions & 2 deletions src/Fieldtypes/Checkboxes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ protected function configFieldItems(): array
'display' => __('Options'),
'instructions' => __('statamic::fieldtypes.checkboxes.config.options'),
'type' => 'array',
'key_header' => __('Key (Value)'),
'value_header' => __('Label'),
'key_header' => __('Key'),
'value_header' => __('Label').' ('.__('Optional').')',
],
'default' => [
'display' => __('Default Value'),
Expand Down
2 changes: 1 addition & 1 deletion src/Fieldtypes/Radio.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ protected function configFieldItems(): array
'display' => __('Options'),
'instructions' => __('statamic::fieldtypes.radio.config.options'),
'type' => 'array',
'value_header' => __('Label'),
'value_header' => __('Label').' ('.__('Optional').')',
],
'inline' => [
'display' => __('Inline'),
Expand Down
2 changes: 1 addition & 1 deletion src/Fieldtypes/Select.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ protected function configFieldItems(): array
'instructions' => __('statamic::fieldtypes.select.config.options'),
'type' => 'array',
'key_header' => __('Key'),
'value_header' => __('Label'),
'value_header' => __('Label').' ('.__('Optional').')',
'add_button' => __('Add Option'),
],
'multiple' => [
Expand Down