Prevent regenerating asset meta file for non-images #3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this comment on the static site generator @tao was finding pages with mp3 assets taking a bonkers amount of time.
Turns out it was because when
widthwas being requested somewhere in augmentation. Width comes from dimensions, dimensions looks in the meta data. If there's a null value in the meta data, it assumes its just missing or invalid and regenerates it.His asset container had a ton of mp3 files, on s3, and would regenerate the meta file for each of them on every page load.
It's an mp3 so the dimensions should be null. This PR adds that short circuit.
The page flies now.