Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 404 error when URLs have both ending slash and query parameters #3494

Merged
merged 6 commits into from
Apr 8, 2021
Merged

Fix 404 error when URLs have both ending slash and query parameters #3494

merged 6 commits into from
Apr 8, 2021

Commits on Apr 7, 2021

  1. Strip ending slash from end of in FrontendController

    @duncanmcclean
    duncanmcclean committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    e46003e View commit details
    Browse the repository at this point in the history

  2. Add test to cover this use case

    @duncanmcclean
    duncanmcclean committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    2e1ee9d View commit details
    Browse the repository at this point in the history

  3. We don't want to be stripping off the slash when it comes to homepages

    @duncanmcclean
    duncanmcclean committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    7bb5a74 View commit details
    Browse the repository at this point in the history

  4. Cleanup

    @duncanmcclean
    duncanmcclean committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    df5575a View commit details
    Browse the repository at this point in the history

  5. Revert that actually

    @duncanmcclean
    duncanmcclean committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    e5dc7b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. Add more tests and simplify

    @jasonvarga
    jasonvarga committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    a20ecb9 View commit details
    Browse the repository at this point in the history