Apply order by traits to search results #3188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for sorting of search:results tag. Issue reference: statamic#2383
|
Whoops, just saw this after I pushed! Fixed in d403f38, but thank you for the PR ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for sorting of search:results tag (e.g.
{{ search:results sort="title:asc" }})Issue reference: #2383
Suggested fix by @jasonvarga on Discord... I've just applied the logic he suggested.
The only possible problem I can see is that you can't sort by search_score:asc or search_score:desc as thing stand.
Apologies if I've missed anything else required to contribute, do let me know if I need to do anything more.