Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide 'Visit URL' button when collection has no route #3080

Merged
merged 6 commits into from
Feb 10, 2021
Merged

Hide 'Visit URL' button when collection has no route #3080

merged 6 commits into from
Feb 10, 2021

Conversation

duncanmcclean
Copy link
Member

This pull request fixes #3072 and will hide the 'Visit URL' button on the entry publish form if the entry's collection doesn't have a route set.

@jasonvarga
Copy link
Member

Thanks for the PR, but please look at the changes I made to your other PR #3039 you recently opened.

These sort of things need to be applied as props so it'll work when the publish form is used within a stack. (e.g. when editing an entry through the entries fieldtype)

I'll mark this as a draft for now.

@jasonvarga jasonvarga marked this pull request as draft January 6, 2021 21:37
@duncanmcclean
Copy link
Member Author

Thanks for the PR, but please look at the changes I made to your other PR #3039 you recently opened.

These sort of things need to be applied as props so it'll work when the publish form is used within a stack. (e.g. when editing an entry through the entries fieldtype)

I'll mark this as a draft for now.

Ah, sorry. I've passed the props into the stacks now. That makes sense.

@duncanmcclean duncanmcclean marked this pull request as ready for review January 6, 2021 22:04
@jasonvarga jasonvarga merged commit 6c6e6e6 into statamic:3.0 Feb 10, 2021
@duncanmcclean duncanmcclean deleted the fix/view-url-button branch February 10, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visit URL button shows on entries in a collection that has no routes
2 participants