Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save button options #2404

Merged
merged 16 commits into from
Sep 15, 2020
Merged

Save button options #2404

merged 16 commits into from
Sep 15, 2020

Conversation

jesseleite
Copy link
Member

@jesseleite jesseleite commented Sep 11, 2020 •
edited
Loading

image (13)

Closes #675.

@jasonvarga jasonvarga marked this pull request as draft September 11, 2020 17:22
@jackmcdade jackmcdade marked this pull request as ready for review September 14, 2020 20:18
@jackmcdade jackmcdade self-requested a review September 14, 2020 20:19
jackmcdade
jackmcdade requested changes Sep 14, 2020
View reviewed changes
Copy link
Member

@jackmcdade jackmcdade left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues that may or may not be directly related but do affect the button state:

  • When editing a draft entry, the published toggle is incorrectly defaulting to on
  • When publishing a previously-draft entry, the publish state is not changed and it stays draft

jackmcdade
jackmcdade approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@jackmcdade jackmcdade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard the previous requested changes. I misunderstood my own UI. So I'm gonna go fix that. This is good to goooooooo!

@jackmcdade jackmcdade merged commit 97ee228 into master Sep 15, 2020
@jackmcdade jackmcdade deleted the feature/save-and-continue branch September 15, 2020 14:42
@jasonvarga jasonvarga mentioned this pull request Sep 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackmcdade jackmcdade jackmcdade approved these changes

@jasonvarga jasonvarga Awaiting requested review from jasonvarga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save & Redirect behavior
2 participants
@jesseleite @jackmcdade