Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] CP nav reordering fixes #11054

Draft
wants to merge 12 commits into
base: 5.x
Choose a base branch
from

Conversation

jesseleite
Copy link
Member

@jesseleite jesseleite commented Nov 5, 2024

It was reported that there was some lingering issues re-ordering CP nav items, partly due to storing preferences in JSON in SQL, but also partly due to some missing implementation.

Todo

  • Test and fix issues at NavTransformer level
    • The transformer is what converts the Vue payload to YAML/JSON when storing preferences
  • Test and fix issues at NavPreferencesNormalizer level
    • The normalizer is what run when reading YAML/JSON
    • This is important for re-ordering, because we support the old reorder: true boolean for backwards compatibility
  • Test and fix issues at NavBuilder level
    • This is where the nav is actually built after reading YAML/JSON and normalizing
    • First the core nav is built, the normalized preferences are applied on top
  • Test with TV2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant