Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Allow configuring the Stache's Cache Store #10303

Merged
merged 7 commits into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions config/stache.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,17 @@

'watcher' => env('STATAMIC_STACHE_WATCHER', 'auto'),

/*
|--------------------------------------------------------------------------
| Cache Store
|--------------------------------------------------------------------------
|
| Here you may configure which Cache Store the Stache uses.
|
*/

'cache_store' => null,

/*
|--------------------------------------------------------------------------
| Stores
Expand Down
1 change: 1 addition & 0 deletions src/Facades/Stache.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* @method static self registerStores($stores)
* @method static mixed stores()
* @method static mixed store($key)
* @method static \Illuminate\Contracts\Cache\Store cacheStore()
* @method static string generateId()
* @method static self clear()
* @method static void refresh()
Expand Down
7 changes: 3 additions & 4 deletions src/Stache/Duplicates.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace Statamic\Stache;

use Illuminate\Support\Facades\Cache;
use Statamic\Stache\Stores\AggregateStore;
use Statamic\Stache\Stores\Store;

Expand Down Expand Up @@ -49,19 +48,19 @@ public function cache()
return;
}

Cache::forever('stache::duplicates', $this->items);
$this->stache->cacheStore()->forever('stache::duplicates', $this->items);
}

public function load()
{
$this->items = Cache::get('stache::duplicates', []);
$this->items = $this->stache->cacheStore()->get('stache::duplicates', []);

return $this;
}

public function clear()
{
Cache::forget('stache::duplicates');
$this->stache->cacheStore()->forget('stache::duplicates');

return $this;
}
Expand Down
9 changes: 4 additions & 5 deletions src/Stache/Indexes/Index.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace Statamic\Stache\Indexes;

use Illuminate\Support\Facades\Cache;
use Statamic\Facades\Stache;
use Statamic\Statamic;

Expand Down Expand Up @@ -76,7 +75,7 @@ public function load()

debugbar()->addMessage("Loading index: {$this->store->key()}/{$this->name}", 'stache');

$this->items = Cache::get($this->cacheKey());
$this->items = Stache::cacheStore()->get($this->cacheKey());

if ($this->items === null) {
$this->update();
Expand Down Expand Up @@ -106,12 +105,12 @@ public function update()

public function isCached()
{
return Cache::has($this->cacheKey());
return Stache::cacheStore()->has($this->cacheKey());
}

public function cache()
{
Cache::forever($this->cacheKey(), $this->items);
Stache::cacheStore()->forever($this->cacheKey(), $this->items);
}

public function updateItem($item)
Expand Down Expand Up @@ -153,7 +152,7 @@ public function clear()
$this->loaded = false;
$this->items = null;

Cache::forget($this->cacheKey());
Stache::cacheStore()->forget($this->cacheKey());
}

public static function currentlyLoading()
Expand Down
13 changes: 9 additions & 4 deletions src/Stache/Stache.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ public function stores()
return $this->stores;
}

public function cacheStore()
{
return Cache::store(config('statamic.stache.cache_store'));
}

public function store($key)
{
if (Str::contains($key, '::')) {
Expand All @@ -85,7 +90,7 @@ public function clear()

$this->duplicates()->clear();

Cache::forget('stache::timing');
$this->cacheStore()->forget('stache::timing');

return $this;
}
Expand Down Expand Up @@ -146,7 +151,7 @@ public function stopTimer()
return $this;
}

Cache::forever('stache::timing', [
$this->cacheStore()->forever('stache::timing', [
'time' => floor((microtime(true) - $this->startTime) * 1000),
'date' => Carbon::now()->timestamp,
]);
Expand All @@ -156,12 +161,12 @@ public function stopTimer()

public function buildTime()
{
return Cache::get('stache::timing')['time'] ?? null;
return $this->cacheStore()->get('stache::timing')['time'] ?? null;
}

public function buildDate()
{
if (! $cache = Cache::get('stache::timing')) {
if (! $cache = $this->cacheStore()->get('stache::timing')) {
return null;
}

Expand Down
8 changes: 4 additions & 4 deletions src/Stache/Stores/BasicStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

namespace Statamic\Stache\Stores;

use Illuminate\Support\Facades\Cache;
use Statamic\Facades\File;
use Statamic\Facades\Stache;
use Symfony\Component\Finder\SplFileInfo;

abstract class BasicStore extends Store
Expand Down Expand Up @@ -77,7 +77,7 @@ protected function getCachedItem($key)
{
$cacheKey = $this->getItemCacheKey($key);

return Cache::get($cacheKey);
return Stache::cacheStore()->get($cacheKey);
}

protected function cacheItem($item)
Expand All @@ -86,12 +86,12 @@ protected function cacheItem($item)

$cacheKey = $this->getItemCacheKey($key);

Cache::forever($cacheKey, $item);
Stache::cacheStore()->forever($cacheKey, $item);
}

public function forgetItem($key)
{
Cache::forget($this->getItemCacheKey($key));
Stache::cacheStore()->forget($this->getItemCacheKey($key));
}

protected function getItemCacheKey($key)
Expand Down
4 changes: 2 additions & 2 deletions src/Stache/Stores/CollectionEntriesStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace Statamic\Stache\Stores;

use Illuminate\Support\Facades\Cache;
use Statamic\Entries\GetDateFromPath;
use Statamic\Entries\GetSlugFromPath;
use Statamic\Entries\GetSuffixFromPath;
Expand All @@ -13,6 +12,7 @@
use Statamic\Facades\File;
use Statamic\Facades\Path;
use Statamic\Facades\Site;
use Statamic\Facades\Stache;
use Statamic\Facades\YAML;
use Statamic\Stache\Indexes;
use Statamic\Stache\Indexes\Index;
Expand Down Expand Up @@ -230,7 +230,7 @@ protected function getCachedItem($key)
{
$cacheKey = $this->getItemCacheKey($key);

if (! $entry = Cache::get($cacheKey)) {
if (! $entry = Stache::cacheStore()->get($cacheKey)) {
return null;
}

Expand Down
3 changes: 1 addition & 2 deletions src/Stache/Stores/ContainerAssetsStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace Statamic\Stache\Stores;

use Illuminate\Support\Facades\Cache;
use Statamic\Facades\AssetContainer;
use Statamic\Facades\Stache;
use Statamic\Statamic;
Expand Down Expand Up @@ -59,7 +58,7 @@ public function paths()
return $this->paths;
}

if ($paths = Cache::get($this->pathsCacheKey())) {
if ($paths = Stache::cacheStore()->get($this->pathsCacheKey())) {
return $this->paths = collect($paths);
}

Expand Down
8 changes: 4 additions & 4 deletions src/Stache/Stores/Keys.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Statamic\Stache\Stores;

use Illuminate\Support\Facades\Cache;
use Statamic\Facades\Stache;
use Statamic\Stache\Exceptions\DuplicateKeyException;

class Keys
Expand All @@ -17,19 +17,19 @@ public function __construct(Store $store)

public function load()
{
$this->keys = Cache::get($this->cacheKey(), []);
$this->keys = Stache::cacheStore()->get($this->cacheKey(), []);

return $this;
}

public function cache()
{
Cache::forever($this->cacheKey(), $this->keys);
Stache::cacheStore()->forever($this->cacheKey(), $this->keys);
}

public function clear()
{
Cache::forget($this->cacheKey());
Stache::cacheStore()->forget($this->cacheKey());
}

private function cacheKey()
Expand Down
18 changes: 9 additions & 9 deletions src/Stache/Stores/Store.php
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public function indexUsage()
{
$key = $this->indexUsageCacheKey();

return $this->usedIndexes = $this->usedIndexes ?? collect(Cache::get($key, []));
return $this->usedIndexes = $this->usedIndexes ?? collect(Stache::cacheStore()->get($key, []));
}

public function cacheIndexUsage($index)
Expand All @@ -116,7 +116,7 @@ public function cacheIndexUsage($index)

$this->usedIndexes = $indexes;

Cache::put($this->indexUsageCacheKey(), $indexes->all());
Stache::cacheStore()->put($this->indexUsageCacheKey(), $indexes->all());
}

protected function indexUsageCacheKey()
Expand Down Expand Up @@ -180,14 +180,14 @@ public function handleFileChanges()

// Get the existing files and timestamps from the cache.
$cacheKey = "stache::timestamps::{$this->key()}";
$existing = collect(Cache::get($cacheKey, []));
$existing = collect(Stache::cacheStore()->get($cacheKey, []));

// Get the files and timestamps from the filesystem right now.
$files = Traverser::filter([$this, 'getItemFilter'])->traverse($this);

// Cache the files and timestamps, ready for comparisons on the next request.
// We'll do it now since there are multiple early returns coming up.
Cache::forever($cacheKey, $files->all());
Stache::cacheStore()->forever($cacheKey, $files->all());

// If there are no existing file timestamps in the cache, there's nothing to update.
if ($existing->isEmpty()) {
Expand Down Expand Up @@ -291,7 +291,7 @@ public function paths()
return $this->paths;
}

if ($paths = Cache::get($this->pathsCacheKey())) {
if ($paths = Stache::cacheStore()->get($this->pathsCacheKey())) {
return $this->paths = collect($paths);
}

Expand Down Expand Up @@ -351,7 +351,7 @@ protected function setPath($key, $path)

protected function cachePaths($paths)
{
Cache::forever($this->pathsCacheKey(), $paths->all());
Stache::cacheStore()->forever($this->pathsCacheKey(), $paths->all());

$this->paths = $paths;

Expand All @@ -361,7 +361,7 @@ protected function cachePaths($paths)
public function clearCachedPaths()
{
$this->paths = null;
Cache::forget($this->pathsCacheKey());
Stache::cacheStore()->forget($this->pathsCacheKey());
}

protected function pathsCacheKey()
Expand All @@ -381,13 +381,13 @@ public function clear()
});

$this->usedIndexes = collect();
Cache::forget($this->indexUsageCacheKey());
Stache::cacheStore()->forget($this->indexUsageCacheKey());

$this->clearCachedPaths();

$this->keys()->clear();

Cache::forget("stache::timestamps::{$this->key()}");
Stache::cacheStore()->forget("stache::timestamps::{$this->key()}");
}

public function warm()
Expand Down
3 changes: 1 addition & 2 deletions src/Stache/Stores/TaxonomyTermsStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
namespace Statamic\Stache\Stores;

use Facades\Statamic\Stache\Traverser;
use Illuminate\Support\Facades\Cache;
use Statamic\Entries\GetSlugFromPath;
use Statamic\Facades\File;
use Statamic\Facades\Stache;
Expand Down Expand Up @@ -151,7 +150,7 @@ public function paths()
return $this->paths;
}

if ($paths = Cache::get($this->pathsCacheKey())) {
if ($paths = Stache::cacheStore()->get($this->pathsCacheKey())) {
return $this->paths = collect($paths);
}

Expand Down
9 changes: 7 additions & 2 deletions tests/Stache/DuplicatesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ public function it_saves_to_the_cache()

$stache = $this->mock(Stache::class);
$stache->shouldReceive('store')->with('test-store')->andReturn($store);
$stache->shouldReceive('cacheStore')->andReturn(Cache::store());

$duplicates = new Duplicates($stache);

Expand Down Expand Up @@ -146,7 +147,9 @@ public function it_loads_from_cache()
{
Cache::forever('stache::duplicates', ['foo' => 'bar']);

$duplicates = new Duplicates($this->mock(Stache::class));
$stache = $this->mock(Stache::class);
$stache->shouldReceive('cacheStore')->andReturn(Cache::store());
$duplicates = new Duplicates($stache);

$return = $duplicates->load();

Expand All @@ -159,7 +162,9 @@ public function it_clears_the_cache()
{
Cache::forever('stache::duplicates', ['foo' => 'bar']);

$duplicates = new Duplicates($this->mock(Stache::class));
$stache = $this->mock(Stache::class);
$stache->shouldReceive('cacheStore')->andReturn(Cache::store());
$duplicates = new Duplicates($stache);

$this->assertNotNull(Cache::get('stache::duplicates'));

Expand Down
2 changes: 2 additions & 0 deletions tests/Stache/Stores/AssetContainersStoreTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use Facades\Statamic\Stache\Traverser;
use Illuminate\Filesystem\Filesystem;
use Illuminate\Support\Facades\Cache;
use PHPUnit\Framework\Attributes\Test;
use Statamic\Assets\Asset;
use Statamic\Contracts\Assets\AssetContainer;
Expand Down Expand Up @@ -115,6 +116,7 @@ public function it_saves_to_disk()
Facades\Stache::shouldReceive('duplicates')->andReturn(optional());
Facades\Stache::shouldReceive('store')->with('users')->andReturn((new UsersStore((new Stache)->sites(['en']), app('files')))->directory($this->tempDir));
Facades\Stache::shouldReceive('isWatcherEnabled')->andReturnTrue();
Facades\Stache::shouldReceive('cacheStore')->andReturn(Cache::store());

$container = Facades\AssetContainer::make('new')
->title('New Container');
Expand Down
Loading
Loading