[5.x] Allow accessing drafts via the REST API with Live Preview #10229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
previously requested changes
May 30, 2024
…-endpoint # Conflicts: # tests/API/APITest.php
|
This works, but feels a bit inconsistent. I know we chatted about this in Slack already and this is what we agreed on, but thinking about it a bit more now, I don't want to develop ourselves into an awkward situation later. For instance I could see eventually allowing filters on the show route, or having the default filtering on the show route. It probably should already do that. e.g. "scheduled" entries aren't showed on the index route, but they are on the show route. You could argue that's a bug. If we "fixed" it then we'd have to factor in this I think we could just fix the live preview issue for now, as that's what it seems like the actual issue is at the moment. |
jasonvarga
changed the title
jasonvarga
deleted the
fix/visibility-of-drafts-via-api-entries-show-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft entries couldn't be viewed in Live Preview, even when the
tokenquery parameter was provided.This PR fixes that by preventing the "entry published" check from happening if a valid Live Preview token is passed in the request.
Closes #10207.