Fix 404 error when URLs have both ending slash and query parameters

[duncanmcclean]

This PR fixes #3469, where you visiting a page with a URL like this would simply 404, /about/?ref=smth.

[jasonvarga]

I guess this is fine, and was about to commit this myself earlier, but it bugs me that we do basically the same thing a few lines earlier.

[duncanmcclean]

I guess this is fine, and was about to commit this myself earlier, but it bugs me that we do basically the same thing a few lines earlier.

Huh, that's a good point. Just pushed up a change to get rid of my new code and just update what's already there.

[duncanmcclean]

I guess this is fine, and was about to commit this myself earlier, but it bugs me that we do basically the same thing a few lines earlier.

Huh, that's a good point. Just pushed up a change to get rid of my new code and just update what's already there.

Nevermind, that seemed to break things, both on my test site and on GH Actions. If you can think of a better/cleaner way, feel free to update this PR/close and commit.

[jasonvarga]

I'm working on this now so you don't need to do anything, but just an FYI, the test you added already passed before any changes were made.

[jasonvarga]

Sorry I take that back. It failed on earlier versions of Laravel. 👍

Don't mind me. 🤐

[jasonvarga]

I added tests that cover the original reason that str_finish line and condition were added (other code has been added since then in other spots that makes it work now) and cleaned it up a bit.