-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating French #2870
Updating French #2870
Conversation
BTHO goofy DT
Continuous improvement
Shouldn't "Collapse" remain "Réduire"? Because it doesn't also mean "Développer". In fact, it's the opposite. Also, I'm not sure where "Step" is used, but in general, it seems like "Étape" suits better than "Incrément". An other thing I noted is "Jeu". Shouldn't it be something like "Ensemble" or "Section". Because in my opinion, "Jeu" is more a fr_FR way to call a "Set" and not an international french way. |
Hello and thanks for your comments.
@jasonvarga Would you mind waiting before merging this commit? Thanks |
Sure, mark it as ready when you're ready 😄 |
Major change: I have changed the translation of "Set" from "Jeu" to "Ensemble" when in use in the context of the Bard and Replicator Fieldtypes. I have kept "Jeu" for Fieldset ("jeu de champs") and Globals ("jeu de globales") though another possibility could be to use "Groupe de". I have also changed the translation of "Maximum" and "Minimum" from "Mximum/Minimum" to "Maximal/Minimal"
I guess you could merge this PR. One could create a fr-CA language file if he/she doesn't find this one to reflect proper practices in Québec. |
Looks good to me! |
No description provided.