Relationship fieldtypes should filter out invalid IDs. Closes #1752

statamic · Sep 21, 2020 · 7f06fc6 · 7f06fc6
1 parent a706eb2
commit 7f06fc6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Fieldtypes/Relationship.php b/src/Fieldtypes/Relationship.php
@@ -227,7 +227,7 @@ public function augment($values)
     {
         $values = collect($values)->map(function ($value) {
             return $this->augmentValue($value);
-        });
+        })->filter()->values();
 
         return $this->config('max_items') === 1 ? $values->first() : $values;
     }

diff --git a/tests/Fieldtypes/EntriesTest.php b/tests/Fieldtypes/EntriesTest.php
@@ -28,7 +28,7 @@ public function setUp(): void
     /** @test */
     public function it_augments_to_a_collection_of_entries()
     {
-        $augmented = $this->fieldtype()->augment(['123', '456']);
+        $augmented = $this->fieldtype()->augment(['123', 'invalid', '456']);
 
         $this->assertInstanceOf(Collection::class, $augmented);
         $this->assertEveryItemIsInstanceOf(Entry::class, $augmented);