VolumeSnapshot #787
Merged
VolumeSnapshot #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamalsaha
reviewed
May 15, 2019
hossainemruz
requested changes
May 16, 2019
suaas21
force-pushed
the
volumeSnapshot
branch
6 times, most recently
from
e39c0a4 to
a47c550
Compare
hossainemruz
requested changes
May 22, 2019
suaas21
force-pushed
the
volumeSnapshot
branch
3 times, most recently
from
1913d45 to
06288e1
Compare
hossainemruz
previously approved these changes
May 23, 2019
tamalsaha
reviewed
May 23, 2019
pkg/util/kubernetes.go
Outdated
| @@ -467,3 +468,21 @@ func WaitUntilDeploymentConfigReady(c oc_cs.Interface, meta metav1.ObjectMeta) e | |||
| return false, nil | |||
| }) | |||
| } | |||
|
|
|||
| func WaitUntilVolumeSnapshotReady(c snapshot_cs.Interface, meta metav1.ObjectMeta) error { | |||
| return wait.PollImmediate(RetryInterval, 30*time.Minute, func() (bool, error) { | |||
There was a problem hiding this comment.
I think we need a user configurable timeout. 30min is just abitrary.
There was a problem hiding this comment.
Agreed. But how can we do it? Any field in BackupConfiguration?
There was a problem hiding this comment.
We have increased the timeout to 2 hour
|
xref: #751 |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks: