Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup and restore PVC #676

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Backup and restore PVC #676

merged 1 commit into from
Mar 20, 2019

Conversation

diptadas
Copy link
Contributor

@diptadas diptadas commented Feb 18, 2019 •
edited by hossainemruz
Loading

@diptadas diptadas force-pushed the pvc branch 2 times, most recently from 1826403 to f598aab Compare February 20, 2019 11:26
@diptadas diptadas force-pushed the pvc branch 8 times, most recently from c11a377 to e451c71 Compare March 1, 2019 11:33
@diptadas diptadas changed the title Add command for PVC backup Backup and restore PVC Mar 1, 2019
@diptadas diptadas marked this pull request as ready for review March 4, 2019 05:55
@diptadas diptadas force-pushed the pvc branch 2 times, most recently from 0068595 to f0f110a Compare March 6, 2019 10:26
@diptadas diptadas force-pushed the pvc branch 4 times, most recently from 540651f to 96e0415 Compare March 20, 2019 09:09
@stashed stashed deleted a comment from codecov-io Mar 20, 2019
@codecov-io
Copy link

codecov-io commented Mar 20, 2019 •
edited
Loading

Codecov Report

Merging #676 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #676   +/-   ##
=======================================
  Coverage   12.84%   12.84%           
=======================================
  Files           3        3           
  Lines         109      109           
=======================================
  Hits           14       14           
  Misses         94       94           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bdf075...5d84eb4. Read the comment docs.

tamalsaha
tamalsaha reviewed Mar 20, 2019
View reviewed changes
hack/docker/setup.sh
@@ -14,7 +14,7 @@ source "$REPO_ROOT/hack/libbuild/common/public_image.sh"

APPSCODE_ENV=${APPSCODE_ENV:-dev}
IMG=stash
RESTIC_VER=${RESTIC_VER:-0.8.3}
RESTIC_VER=${RESTIC_VER:-0.9.4}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be done. This breaks existing users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been handled in another PR

@tamalsaha tamalsaha merged commit 30993c0 into master Mar 20, 2019
@tamalsaha tamalsaha deleted the pvc branch March 20, 2019 10:05
@hossainemruz hossainemruz mentioned this pull request Mar 28, 2019
Closed
@hossainemruz hossainemruz mentioned this pull request Mar 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hossainemruz hossainemruz hossainemruz approved these changes

@tamalsaha tamalsaha tamalsaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diptadas @codecov-io @tamalsaha @hossainemruz