Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nil pointer check is missing in metric handling #881

Closed
hossainemruz opened this issue Aug 29, 2019 · 0 comments · Fixed by #891
Closed

Nil pointer check is missing in metric handling #881

hossainemruz opened this issue Aug 29, 2019 · 0 comments · Fixed by #891
Assignees
@hossainemruz
Labels
bug

Comments

@hossainemruz
Copy link
Contributor

stash/pkg/restic/metrics.go

Line 424 in 50f69ff

if *repoStats.Integrity {

@hossainemruz hossainemruz self-assigned this Aug 29, 2019
@hossainemruz hossainemruz mentioned this issue Sep 2, 2019
Merged
7 tasks
tamalsaha pushed a commit that referenced this issue Sep 10, 2019
@hossainemruz @tamalsaha
Improve Error Handling + Code refactor (#891)
5f49f5d 
Fixes: #881

**Error and Metrics Handling:**

- [x] BackupConfiguration Controller:
  - Failed to trigger workload controller:
	- Write event to BackupConfiguration
    - Log error
  - Failed to ensure cronjob:
    - Write event to BackupConfiguration
    - Log error
- [x] BackupSession Controller:
	- Failed to ensure backup job:
      - Write event to BackupSession
      - Log error
      - Fail BackupSeesion
	- Backup session failed:
      - Set BackupSession phase to "Failed"
      - Write event to BackupSession
      - Send backup session specific metrics
	- BackupSession succeeded:
	  - Set BackupSession phase to "Succeeded"
	  - Write event to BackupSession
	  - Send backup session specific metrics
- [x] Auto Backup:
	- Failed/Succeeded to create/delete auto backup resources
	  - Write event to the respective resource
	  - Write log
- [x] Workload Controller:
	- Failed/Succeeded to inject/delete stash sidecar/init-container
	  - Write event to workload
	  - Write log
- [x] RestoreSession Controller:
	- Failed to create restore job
	  - Write event to RestoreSession
	  - Write log
	  - Fail RestoreSession
	- Restore session failed:
		- Set RestoreSession phase to "Failed"
        - Write event to RestoreSession
        - Send restore session specific metrics
	- RestoreSession succeeded:
	  - Set RestoreSession phase to "Succeeded"
	  - Write event to RestoreSession
	  - Send restore session specific metrics
- [x] Sidecar:
	- Failed to start BackupSession controller
		- Write event to BackupConfiguration
		- Write log
		- Fail the container so it restart
	- Succeeded to start BackupSession controller
		- Write event to BackupConfiguration
		- Write log
	- Failed/Succeeded to take backup
		- Update status of the BackupSession
		- Write log
- [x] Init-container/Backup Job:
	- Failed/Succeeded to restore
		- Update status of the RestoreSession
		- Write log
		- Fail the container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hossainemruz hossainemruz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Error Handling + Code refactor stashed/stash
1 participant
@hossainemruz