Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stash broken cli #148

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Fix stash broken cli #148

merged 1 commit into from
Jan 31, 2022

Conversation

hmsayem
Copy link
Member

@hmsayem hmsayem commented Jan 25, 2022 •
edited by hossainemruz
Loading

Signed-off-by: hmsayem [email protected]

Fixes stashed/stash#1110

@hmsayem hmsayem force-pushed the bug_fix branch 2 times, most recently from 1fd88b3 to f69e816 Compare January 25, 2022 11:05
hossainemruz
hossainemruz requested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use apimachinery master branch
  • Use stash master branch
  • Delete docker package if not necessary.

pkg/delete_snapshot.go Outdated Show resolved Hide resolved
pkg/delete_snapshot.go Show resolved Hide resolved
pkg/download.go Outdated Show resolved Hide resolved
pkg/download.go Show resolved Hide resolved
@hmsayem hmsayem force-pushed the bug_fix branch 2 times, most recently from 15d5c77 to 8481230 Compare January 28, 2022 06:38
hossainemruz
hossainemruz requested changes Jan 31, 2022
View reviewed changes
pkg/cli.go Outdated Show resolved Hide resolved
pkg/cli.go Outdated Show resolved Hide resolved
pkg/clone_pvc.go Outdated Show resolved Hide resolved
pkg/create_backupconfiguration.go Outdated Show resolved Hide resolved
pkg/create_restoresession.go Outdated Show resolved Hide resolved
pkg/delete_snapshot.go Outdated Show resolved Hide resolved
pkg/download.go Outdated Show resolved Hide resolved
pkg/download.go Outdated Show resolved Hide resolved
pkg/unlock.go Outdated Show resolved Hide resolved
pkg/unlock.go Show resolved Hide resolved
@hmsayem
fix stash cli
b23042b 
Signed-off-by: hmsayem <[email protected]>
@hossainemruz hossainemruz added the automerge Kodiak will auto merge PRs that have this label label Jan 31, 2022
@kodiakhq kodiakhq bot merged commit 34e30bd into master Jan 31, 2022
@kodiakhq kodiakhq bot deleted the bug_fix branch January 31, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hossainemruz hossainemruz hossainemruz approved these changes

@tamalsaha tamalsaha Awaiting requested review from tamalsaha

@piyush1146115 piyush1146115 Awaiting requested review from piyush1146115

Assignees
No one assigned
Labels
automerge Kodiak will auto merge PRs that have this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubectl-stash download broken
2 participants
@hmsayem @hossainemruz