Markers can have end time #5311
Conversation
MinasukiHikimuna
force-pushed
the
issues/3147
branch
from
2320379
to
57c2d59
Compare
|
Added GraphQL documentation for seconds and end_seconds as recommended by stg-annon. |
MinasukiHikimuna
force-pushed
the
issues/3147
branch
from
15b9006
to
c5b1283
Compare
|
There were two linting errors that weren't for some reason detected when I run |
|
Forgot to run Prettier format after the lint fixes. |
|
Not strictly related, but .... Is it possible to have these also be sub-second? Since they're already a float maybe for end and start we can just skip the Math.round(getPlayerPosition() ? I often find a part of a scene etc starts/ends at a weird spot, or a marker will need that precision to avoid starting at an awkward point etc. |
I agree that it would be useful but as you said, it is not strictly related. This is just a first step in improving markers so I would prefer to get this merged rather than including all kinds of related changes. For example the player could surely be changed somehow with the introduction of end times but that should be in a separate PR. |
MinasukiHikimuna
force-pushed
the
issues/3147
branch
from
65a1f81
to
b7cd80a
Compare
|
Updated the pull request on top of current develop so the migration numbers match. |
Other metadata sources such as ThePornDB and timestamp.trade support end times for markers but Stash did not yet support saving those. This is a first step which only allows end time to be set either via API or via UI. Other aspects of Stash such as video player timeline are not yet updated to take end time into account. - User can set end time when creating or editing markers in the UI or in the API. - End time cannot be before start time. This is validated in the backend and for better UX also in the frontend. - End time is shown in scene details view or markers wall view if present. - Existing markers in the database will be updated to have -1 for end. - GraphQL API does not require end_seconds. Omitted end_seconds will default to -1.
- 'seconds' is the required start time of a marker (in seconds). - 'end_seconds' is an optional end time of a marker (in seconds). Both fields support decimals.
MinasukiHikimuna
force-pushed
the
issues/3147
branch
from
b7cd80a
to
446e99a
Compare
Other metadata sources such as ThePornDB and timestamp.trade support end times for markers but Stash did not yet support saving those. This is a first step which only allows end time to be set either via API or via UI. Other aspects of Stash such as video player timeline are not yet updated to take end time into account.
Closes #3147.