Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched tests to use latest stable chromium #708

Merged
merged 1 commit into from
Aug 22, 2016
Merged

Conversation

noisecapella
Copy link
Contributor

What's this PR do?

Switched from Firefox to Chromium. This was part of the work to fix the build which ended up not being necessary but it's still a good idea since this is the only browser supported

@annagav
Copy link
Contributor

annagav commented Aug 19, 2016

@noisecapella, Could you please take a look at the 'Developers Guide' on selenium testing to see if it needs to be updated with these new changes?

@pdpinch
Copy link
Contributor

pdpinch commented Aug 19, 2016

I can take a look. I already noticed a few cosmetic errors in these instructions.

@noisecapella
Copy link
Contributor Author

Sure, from a quick glance it looks we need to update:

  • the port changed from 4444 to 9515 (not sure what 14444 was for)
  • Instead of the seleniumdriver jar it now uses the chromedriver binary.

@annagav
Copy link
Contributor

annagav commented Aug 22, 2016

👍

@noisecapella
Copy link
Contributor Author

I'll merge this then create an issue to update the developer's guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants