Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY out directional modifiers #17

Merged
merged 2 commits into from
Mar 26, 2015
Merged

DRY out directional modifiers #17

merged 2 commits into from
Mar 26, 2015

Conversation

fspoettel
Copy link
Contributor

Make DRY mixins optional and non-default, GZIP negates the difference anyway. This results in much improved output traceability.

Remove modifiers:

top

default
x-rev
y-rev
rev
Added modifiers:

rev (replaces x-rev)
flip (replaces y-rev)
It was previously not possible to combine rev+flip, now it is.

Fix modifier error-handling
Use SASSy margin/padding syntax

 - Removed „rev, x-rev, y-rev“ in favour of „rev, flip and a
combination of those two
 - Do not set flex-direction: row, it is a consistent default
 -
fspoettel pushed a commit that referenced this pull request Mar 26, 2015
DRY out directional modifiers
@fspoettel fspoettel merged commit fc731e2 into master Mar 26, 2015
@fspoettel fspoettel deleted the clean-modifiers branch April 5, 2015 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant