Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HrpsysSeqStateROSBridgeImpl.cpp: sensor->localR is world coords #925

Merged
merged 1 commit into from
Apr 20, 2016

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Apr 14, 2016

nextage/hironxで手先にセンサをつけた時(以下のモデルを使う
https://gist.github.com/k-okada/872470bf55a6c15f8a1abc69aadc7397

にTFの角度がずれるという問題です.

screenshot from 2016-04-15 00 39 31

nextage/hironx の特徴として肩の関節が15どずれているというのがあって,
それそのままセンサのtfに反映されていそうです.

で,

https://github.com/fkanehiro/openhrp3/blob/master/hrplib/hrpModel/ModelLoaderUtil.cpp#L403

sensor->localR = Rs * R;

となっていてlocalRだけど,リンク想定ではなくてベース相対というやつなんかと思っていて,
これってどこかで分かりづらくない?でも昔からこれでやっているから,というような議論があった
気がしますが,そうだと解釈てこのPRをつくりました.

screenshot from 2016-04-15 00 31 51

どうでしょうか?

@130s
Copy link
Contributor

130s commented Apr 14, 2016

NEXTAGE (sim) で,手首が傾く問題の解消を確認ました.
また,デフォルトの main.wrl に差し戻しても特に見た目上の問題はみあたりませんでした.

Travis が2個失敗していますがよく分かりません.1個は Hydro

>> hcf.setJointAngles([10,10,10,10,10,10,10,10,10], 1)
Traceback (most recent call last):
  File "/home/travis/ros/ws_rtmros_common/install/share/hrpsys_tools/scripts/hrpsys_tools_config.py", line 44, in <module>
    exec(args.c[0])
  File "<string>", line 1, in <module>
  File "/opt/ros/hydro/lib/python2.7/dist-packages/hrpsys/hrpsys_config.py", line 978, in setJointAngles
    return self.seq_svc.setJointAngles(ret, tm)
AttributeError: 'NoneType' object has no attribute 'setJointAngles'

もうひとつは Jenkins に接続できないようです.

@@ -178,7 +178,10 @@ RTC::ReturnCode_t HrpsysSeqStateROSBridgeImpl::onInitialize()
rpy = hrp::rpyFromRot(sensor->localR * m);
}
else
rpy = hrp::rpyFromRot(sensor->localR);
{
// localR is parnet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo k-okada#9 で修正しました

@snozawa
Copy link
Contributor

snozawa commented Apr 15, 2016

どわすれしたのですが、sensor->Rsってなにがはいってるんでしたっけ?

@130s
Copy link
Contributor

130s commented Apr 15, 2016

Travis passed.

@k-okada
Copy link
Member Author

k-okada commented Apr 15, 2016

https://github.com/fkanehiro/openhrp3/blob/master/hrplib/hrpModel/Link.h#L123
によると,

        Matrix33 Rs;    ///< relative attitude of the link segment (self
local)

親リンクからの相対座標?

◉ Kei Okada

On Fri, Apr 15, 2016 at 10:36 AM, Shunichi Nozawa [email protected]
wrote:

どわすれしたのですが、sensor->Rsってなにがはいってるんでしたっけ?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#925 (comment)

@130s
Copy link
Contributor

130s commented Apr 18, 2016

@snozawa いかがでしょうか?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants