use transformable_markers for kiva_pod #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pazeshun
requested changes
Aug 7, 2017
knorth55
force-pushed
the
trasformable-kivapod-marker
branch
from
f0ec1f8 to
a650c7b
Compare
|
updated |
pazeshun
approved these changes
Aug 8, 2017
wkentaro
requested changes
Aug 8, 2017
| @@ -393,7 +393,7 @@ | |||
| (setq box-list (send box-msg :boxes)) | |||
| (setq bin-list (list :a :b :c :d :e :f :g :h :i :j :k :l)) | |||
| (dolist (bin bin-list) | |||
| (setf (gethash bin _bin-boxes) (car box-list)) | |||
| (sethash bin _bin-boxes- (car box-list)) | |||
There was a problem hiding this comment.
@pazeshun Could you please the naming of slots in baxter-rgv5.l?
There was a problem hiding this comment.
Sorry for late response.
I'll change slots of baxterrgv5-interface.l and baxterrgv5.l after this PR.
knorth55
force-pushed
the
trasformable-kivapod-marker
branch
from
a650c7b to
8d25a85
Compare
wkentaro
approved these changes
Aug 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
jsk_2016_01_baxter_apc