-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hrpsys_config.py in seq walking sample. #79
Use hrpsys_config.py in seq walking sample. #79
Conversation
|
||
# set path to hrpsys to get import rpy, see <hrpsys>/test/test-samplerobot.py for using HrpsysConfigurator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not delete line for catkin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines are copied from hrpsys_tools_config.py:
https://github.com/start-jsk/rtmros_common/blob/master/hrpsys_tools/scripts/hrpsys_tools_config.py
I thought hrpsys_tools_config.py worked on both rosbuild and catkin.
Is this correct?
sensor_ros_bridge_connect.py has another way to import hrpsys_config.py.
https://github.com/start-jsk/rtmros_common/blob/master/hrpsys_ros_bridge/scripts/sensor_ros_bridge_connect.py
I'd like to know which is the best way to import hrpsys_config.py.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/start-jsk/rtmros_common/blob/9c30250a5df5793dd9df0b161fc7642835755b67/hrpsys_ros_bridge/scripts/hrpsys_dashboard is the good example of writing python code that works on both rosmake and catkin.
the example you mentioned had some trouble on same situation (sorry I can't point out but it actually have problem)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I referred [1] and I checkout committed PR works both on rosbuild and catkin.
before merging this code, please review proposed process -> start-jsk/rtmros_common#449 |
I read start-jsk/rtmros_common#449. Currently getRTCList is overwrote in samplerobot-walk.py. |
…latest autoablancer idl
Use hrpsys_config.py for creating RTCs, connecting of ports, and activation
according to discussion in
#65 (comment)