Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix directory_in_root integration test on Windows #181

Merged
merged 3 commits into from
Aug 18, 2019

Conversation

johnmerchant
Copy link
Contributor

Description

This merge request resolves the failing directory_in_root integration test on Windows

Motivation and Context

The test was failing because /usr is an invalid path on Windows.

I have changed the directory_in_root test to have both a Windows and Unix version by using the #[cfg(target_os)] attribute.

Closes #97

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

cargo test on Windows

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that explains it!
The same root directories aren't available in Windows 😅

Thank you for tackling this @jmercha! I'll be readding Windows test runs and releases to Azure Pipelines. 👍

@matchai matchai changed the title Fix directory_in_root integration test on Windows fix: Fix directory_in_root integration test on Windows Aug 18, 2019
@matchai matchai merged commit 5af70b9 into starship:master Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate integration test failures occurring on Windows
2 participants